[webkit-reviews] review denied: [Bug 39483] Building Efl port fails : [Attachment 56703] fix efl build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 21 11:29:22 PDT 2010


Darin Adler <darin at apple.com> has denied Jos van den Oever
<jos.van.den.oever at kogmbh.com>'s request for review:
Bug 39483: Building Efl port fails
https://bugs.webkit.org/show_bug.cgi?id=39483

Attachment 56703: fix efl build
https://bugs.webkit.org/attachment.cgi?id=56703&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for working on this. The ChangeLog still needs a bit of work.

> +	   Need a short description and bug URL (OOPS!)

You need to replace this with the bug URL.

> +	   Reviewed by NOBODY (OOPS!).

This you don't need to fill in until after reviewing, and the person landing it
will take care of it.

> +	   No new tests. (OOPS!)

This line you need to delete.

The only OOPS that should be left in the ChangeLog int he patch you upload
should be in the "Reviewed by" line.


More information about the webkit-reviews mailing list