[webkit-reviews] review granted: [Bug 39495] All callable objects should have a global object reference : [Attachment 56726] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 39495: All callable objects should have a global object reference
https://bugs.webkit.org/show_bug.cgi?id=39495

Attachment 56726: Patch
https://bugs.webkit.org/attachment.cgi?id=56726&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Please mention your performance testing results in the ChangeLog.

+	 All objects that may ever return a value other CallTypeNone
+	 or ConstructTypeNone now get a global object in their constructor

Typo: Should be "other than".

Please fix EWS failures.

Since we can't use C++ subclassing, I wonder if there's some other centralized
choke-point we can use for ensuring our anonymous slot contract. The ASSERT is
good, but it would be better to catch an error even earlier, like at object
construction time. For example, maybe we need a Structure::createCallable.

r=me