[webkit-reviews] review denied: [Bug 39479] Add DeviceOrientation and DeviceOrientationClient : [Attachment 56705] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 39479: Add DeviceOrientation and DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=39479

Attachment 56705: Patch
https://bugs.webkit.org/attachment.cgi?id=56705&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/ChangeLog:14
 +	    No new tests are possible at this time.
Please explain why.  And promise to land them soon.  :-)

WebCore/dom/DeviceOrientation.cpp:47
 +	UNUSED_PARAM(alpha);
You may need to include wtf/UnusedParam.h

WebKit/chromium/src/WebViewImpl.cpp:264
 +			    0));
I don't know why these are split across multiple lines like this, but it
doesn't match WebKit style...so mind putting these all on one line?

WebKit/mac/WebView/WebView.mm:666
 +	_private->page = new Page(new WebChromeClient(self), new
WebContextMenuClient(self), new WebEditorClient(self), new WebDragClient(self),
new WebInspectorClient(self), new WebPluginHalterClient(self),
geolocationControllerClient, deviceOrientationClient);
Where is deviceOrientationClient defined?