[webkit-reviews] review denied: [Bug 39483] Building Efl port fails : [Attachment 56700] fix efl build

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Jos van den Oever
<jos.van.den.oever at kogmbh.com>'s request for review:
Bug 39483: Building Efl port fails
https://bugs.webkit.org/show_bug.cgi?id=39483

Attachment 56700: fix efl build
https://bugs.webkit.org/attachment.cgi?id=56700&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> @@ -76,7 +76,7 @@ SET(WebKit_LIBRARY_TYPE SHARED)
>  # Port-specific options
>  #
-----------------------------------------------------------------------------
>  INCLUDE(OptionsCommon)
> -INCLUDE(Options${PORT})
> +INCLUDE(Options${PORT} OPTIONAL)

I didn't see any explanation of this change in your commit message.

The WebKit project uses ChangeLog files as well as commit messages to explain
changes. You can use the prepare-ChangeLog script to add a skeleton ChangeLog
entry to the appropriate file, and then you can edit the entry manually. We
then use the ChangeLog entry as the commit message.

If you add a ChangeLog entry and explain the above change, I think we can get
this landed.