[webkit-reviews] review denied: [Bug 39479] Add DeviceOrientation and DeviceOrientationClient : [Attachment 56692] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 39479: Add DeviceOrientation and DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=39479

Attachment 56692: Patch
https://bugs.webkit.org/attachment.cgi?id=56692&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
You forget WebCore/CMakeLists.txt and visual studio.

WebCore/dom/DeviceOrientation.h:38
 +	// TODO: Add methods to start and stop the service.
FIXME

WebCore/dom/DeviceOrientation.cpp:45
 +	// TODO: Fire DeviceOrientationEvents on the window object of all
frames
FIXME