[webkit-reviews] review denied: [Bug 32077] textarea grows when you type : [Attachment 56671] took feedbacks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 20 22:46:41 PDT 2010


Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 32077: textarea grows when you type
https://bugs.webkit.org/show_bug.cgi?id=32077

Attachment 56671: took feedbacks
https://bugs.webkit.org/attachment.cgi?id=56671&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
LayoutTests/ChangeLog:13
 +	    * fast/forms/textarea-percentage-dimensions.html: Added.
You need to update ChangeLog for textarea-percentage-dimensions-expected.txt.


LayoutTests/fast/forms/script-tests/textarea-percentage-dimensions.js:13
 +	shouldBe("window.heightBeforeInsert", "window.heightAfterInsert");
If one of the test cases failed, it's not easy to identify what test case
failed.
Would you improve test result readabily?  e.g.	adding debug("A test for " +
style); before shouldBe().



LayoutTests/ChangeLog:5
 +	    Textarea grows when you type.
The 1-line description is unclear.   Textarea should grow when you type?
Textarea should not grow when you type?


More information about the webkit-reviews mailing list