[webkit-reviews] review denied: [Bug 39440] [chromium] Adds Geolocation support to DumpRenderTree. : [Attachment 56620] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 39440: [chromium] Adds Geolocation support to DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=39440

Attachment 56620: Patch
https://bugs.webkit.org/attachment.cgi?id=56620&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
Thank you for making the patch.
WebKitTools/DumpRenderTree/chromium is not the primary tester yet.  You need to
change webkit/tools/test_shell/ in Chromium too.


WebKit/chromium/public/WebGeolocationServiceMock.h:55
 +	static bool m_mockGeolocationPermission;
We don't prepend "m_" for a static field in WebKit style.


WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1303
 +     
WebGeolocationServiceMock::setMockGeolocationError(arguments[0].toInt32(),
WebString::fromUTF8(arguments[1].toString()));
nit: We have cppVariantToWebString().


r- for the style error.