[webkit-reviews] review granted: [Bug 39463] Avoid flushing CA layers when a layout is pending : [Attachment 56657] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 20 18:49:00 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 39463: Avoid flushing CA layers when a layout is pending
https://bugs.webkit.org/show_bug.cgi?id=39463

Attachment 56657: Patch
https://bugs.webkit.org/attachment.cgi?id=56657&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +bool WebView::shouldRender() const
> +{
> +    Frame* coreFrame = core(m_mainFrame);
> +    if (!coreFrame)
> +	   return true;
> +    FrameView* frameView = coreFrame->view();
> +    if (frameView)
> +	   return !frameView->layoutPending();
> +
> +    return true;
> +}

I think reversing the last condition would be clearer.

r=me


More information about the webkit-reviews mailing list