[webkit-reviews] review denied: [Bug 36359] Double clicking page's last editable inline element doesn't select a word. : [Attachment 51710] v2; remove redundant null-check

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 36359: Double clicking page's last editable inline element doesn't select a
word.
https://bugs.webkit.org/show_bug.cgi?id=36359

Attachment 51710: v2; remove redundant null-check
https://bugs.webkit.org/attachment.cgi?id=51710&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Sorry the review took so long.

Doesn't previousBoundary have the same bug? Would be good to understand why it
doesn't or to fix it and add a testcase for that as well. r- for the
previousBoundary issue.

LayoutTests/editing/selection/doubleclick-inline-last-contenteditable.html:45
 +  function flushLog()
This doesn't seem necessary since you only call log once in this test. You can
move the logging logic into the log function.

LayoutTests/editing/selection/doubleclick-inline-last-contenteditable.html:29
 +	eventSender.leapForward(1);
These leapForward calls are not necessary to test double-click selecting a
word. Just the mouseMoveTo, mouseDown and mouseUp calls are needed.

LayoutTests/editing/selection/doubleclick-inline-last-contenteditable.html:21
 +	pos.y += target.clientHeight/2;
nit: webkit style: there should be spaces around the /