[webkit-reviews] review denied: [Bug 39445] [chromium] Change WebMediaPlayer interface so buffered() isn't const : [Attachment 56630] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 20 15:08:21 PDT 2010
David Levin <levin at chromium.org> has denied Victoria <vrk at google.com>'s request
for review:
Bug 39445: [chromium] Change WebMediaPlayer interface so buffered() isn't const
https://bugs.webkit.org/show_bug.cgi?id=39445
Attachment 56630: Patch
https://bugs.webkit.org/attachment.cgi?id=56630&action=review
------- Additional Comments from David Levin <levin at chromium.org>
Two sided commits are strongly discouraged (because they require a lot of
coordination and cause breakage that hides test failures, etc.). Please try to
find a way to do the change without this.
Perhaps just committing the chromium side first but implementing both overloads
will let you land this change after (and then finally removing one of the
overloads in chromium when the deps are rolled to pick up this patch being
landed).
More information about the webkit-reviews
mailing list