[webkit-reviews] review granted: [Bug 39426] Calls to CallJNIMethodIDA() in JavaInstance::invokeMethod() are required on Android : [Attachment 56595] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 20 14:11:15 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 39426: Calls to CallJNIMethodIDA() in JavaInstance::invokeMethod() are
required on Android
https://bugs.webkit.org/show_bug.cgi?id=39426

Attachment 56595: Patch
https://bugs.webkit.org/attachment.cgi?id=56595&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I would appreciate a more detailed explanation of the change. How is this a
build fix? Why are these calls required?

I'm going to say r=me since this helps Android, but it's a deprecated code
path, so an explanation of why it's needed (and when it can be finally removed)
would help a lot.


More information about the webkit-reviews mailing list