[webkit-reviews] review granted: [Bug 38548] REGRESSION: Weird focus behavior affects quoting on University of Washington message board system : [Attachment 56619] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 20 14:00:03 PDT 2010


Ojan Vafai <ojan at chromium.org> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 38548: REGRESSION: Weird focus behavior affects quoting on University of
Washington message board system
https://bugs.webkit.org/show_bug.cgi?id=38548

Attachment 56619: Patch
https://bugs.webkit.org/attachment.cgi?id=56619&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Please improve the comment before committing.

WebCore/page/FocusController.cpp:516
 +		// In case selection was in an input or textarea we need to
clear the selection. See bug 38696.
I find this comment a bit confusing and it doesn't say much over the one below.
How about:
// Don't clear the selection for contentEditable elements, but do clear it for
input and textarea. See bug 38696.


More information about the webkit-reviews mailing list