[webkit-reviews] review requested: [Bug 38179] [Qt] QWebPage::setViewportSize() forces two layout of the render tree : [Attachment 56621] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin.poulain at nokia.com> has asked  for review:
Bug 38179: [Qt] QWebPage::setViewportSize() forces two layout of the render
tree
https://bugs.webkit.org/show_bug.cgi?id=38179

Attachment 56621: Patch
https://bugs.webkit.org/attachment.cgi?id=56621&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
The real patch. From my previous comments:

> -I need to make sure the case (!newHasHorizontalScrollbar &&
hasHorizontalScrollbar && vScroll != ScrollbarAlwaysOn) will not fail because
of cMaxUpdateScrollbarsPass == 2
This is not a problem in the updated version because I only care about the case
when newHasHorizontalScrollbar is true.
The other case does not need change since the behavior is already optimal.

> -I need to understand why the call inside ScrollView::setFrameRect() were in
reverse order
Unfortunately, there is no history for that. This code comes from a big merge
from the Windows port of WebKit.