[webkit-reviews] review granted: [Bug 39288] Geolocation causes DOMWindow to leak if position requests are in progress when the page is navigated away : [Attachment 56590] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Steve Block <steveblock at google.com>'s
request for review:
Bug 39288: Geolocation causes DOMWindow to leak if position requests are in
progress when the page is navigated away
https://bugs.webkit.org/show_bug.cgi?id=39288

Attachment 56590: Patch
https://bugs.webkit.org/attachment.cgi?id=56590&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	// Stop the Geolocation object, if present. This call is made after the
unload
> +	// event has fired, so no new Geolocation activity is possible.
> +    if (m_frame->domWindow()->navigator()->optionalGeolocation())
> +	   m_frame->domWindow()->navigator()->optionalGeolocation()->stop();

Incorrect indentation of the comment here.

What about if some other frame in the same domain has access to this frame, and
later tries to trigger some geolocation activity in this frame with JavaScript
code?

r=me