[webkit-reviews] review canceled: [Bug 39433] editingBehavior settings needs to be set back to a reasonable default between tests : [Attachment 56608] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has canceled Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 39433: editingBehavior settings needs to be set back to a reasonable
default between tests
https://bugs.webkit.org/show_bug.cgi?id=39433

Attachment 56608: Patch
https://bugs.webkit.org/attachment.cgi?id=56608&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
via IRC:
(10:57:24 AM) ojan: mrobinson: i'd rather see a shared method in Settings
(10:57:53 AM) ojan: mrobinson: that way, if a port changes which editing
behavior they use ona  platform, they only change it in one place
(11:01:09 AM) ojan: mrobinson: so, i'm thinking...add
Settings::resetEditingBehavior and move the logic from the Settings constructor
into that method. then call the method instead of setEditingBehavior.
(11:05:48 AM) ojan: so, i'm just staying to move those 7 lines of code into
Settings::resetEditingBehavior and instead call that method from the
constructor