[webkit-reviews] review granted: [Bug 39206] [GStreamer] video painting support on mac port : [Attachment 56227] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 20 09:45:21 PDT 2010


Eric Carlson <eric.carlson at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 39206: [GStreamer] video painting support on mac port
https://bugs.webkit.org/show_bug.cgi?id=39206

Attachment 56227: proposed patch
https://bugs.webkit.org/attachment.cgi?id=56227&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> + *
> + * You should have received a copy of the GNU Library General Public License

> + * aint with this library; see the file COPYING.LIB.  If not, write to
>
This typo is back, "aint" should be "along" (see
https://bugs.webkit.org/show_bug.cgi?id=36442).

> +    CGColorSpaceRef colorSpace = CGColorSpaceCreateDeviceRGB();
> +    CGImageRef frameImage = CGImageCreate(size.width(), size.height(), 8,
32, size.width()*4, colorSpace,
> +	   kCGBitmapByteOrder32Little | kCGImageAlphaFirst, provider.get(), 0,
false, kCGRenderingIntentDefault);
> +    m_image = BitmapImage::create(frameImage);
> +}
> 
You are leaking the CGColorSpaceRef. Since your frames are always in the same
color space, you could use a static.

r=me with these changes


More information about the webkit-reviews mailing list