[webkit-reviews] review granted: [Bug 39366] Move view-related functions from Frame to FrameView : [Attachment 56500] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 39366: Move view-related functions from Frame to FrameView
https://bugs.webkit.org/show_bug.cgi?id=39366

Attachment 56500: Patch
https://bugs.webkit.org/attachment.cgi?id=56500&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/css/CSSStyleSelector.cpp:4043
 +			    multiplier *= view->textZoomFactor();
much cleaner, thanks.

WebCore/dom/MouseRelatedEvent.cpp:137
 +	float zoomFactor = pageZoomFactor(this);
MUCH cleaner.  Thanks again!

WebCore/html/HTMLBodyElement.cpp:268
 +	document->updateLayoutIgnorePendingStylesheets();
This is a behavior change.  We didn't use to bother to layout when the view
didn't exist.  Is this intentional?

WebCore/page/FrameView.h:297
 +	int m_borderX;
This is destined to be an IntSize in a later patch. :)

WebKit/efl/ewk/ewk_frame.cpp:974
 +	    return -1;
-1?

LGTM.