[webkit-reviews] review granted: [Bug 39402] [chromium] disable spelling suggestions if spellcheck=false : [Attachment 56558] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 39402: [chromium] disable spelling suggestions if spellcheck=false
https://bugs.webkit.org/show_bug.cgi?id=39402

Attachment 56558: Patch
https://bugs.webkit.org/attachment.cgi?id=56558&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 56558 [details] [details])
> > WebKit/chromium/src/ContextMenuClientImpl.cpp:205
> >  +		    data.isSpellCheckingEnabled = true;
> > Should we leave this line in a case of no misspelledWord?
> 
> I left it in to be consistent with Safari.  This means that the context menu
will still show a check mark by "Spellchecking in this field".	I did it this
way in Safari because you can imagine a div with spellchecking enabled, with a
single span inside it that has spellchecking disabled.	It seems more
consistent to treat the whole field as "spellcheck enabled" even if you click
in the span.  I think it would be confusing if the check mark changed depending
on which node you happened to click on within a single content editable node.

Ok, that's reasonable.