[webkit-reviews] review granted: [Bug 39296] build-webkit doesn't recognize Platform SDK on win64 : [Attachment 56535] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 39296: build-webkit doesn't recognize Platform SDK on win64
https://bugs.webkit.org/show_bug.cgi?id=39296

Attachment 56535: Patch
https://bugs.webkit.org/attachment.cgi?id=56535&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
> -    return if -e $windowsPlatformSDKRegistryEntry;
> +    # FIXME It would be better to detect if this is a 64-bit Windows build
> +    # and only check the appropriate entry. But for now we just blindly
check
> +    # both.

You are missing a ':' after FIXME in the comment, which is necessary for some
editors, such as Xcode, to notice that this is a special comment.

Since the last line of this comment is only one word, I would suggest
collapsing it into the second line and push the word "and" (at the start of the
second line) into the first line so that the two lines are roughly the same
size.

Also, I think it might be a bit clearer to write the first sentence as "It
would be better to detect whether we are using 32-bit or 64-bit Windows ...":

# FIXME: It would be better to detect whether we are using 32- or 64-bit
Windows
# and only check the appropriate entry. But for now we just blindly check both.