[webkit-reviews] review granted: [Bug 39131] Refactor text encoding detection logic in FileReader : [Attachment 56531] Proposed Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 39131: Refactor text encoding detection logic in FileReader
https://bugs.webkit.org/show_bug.cgi?id=39131

Attachment 56531: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=56531&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+    m_result = m_decoder->decode(&m_rawData.at(0), m_rawData.size());

One also needs to call flush() to make sure that e.g. incomplete UTF-8
sequences at the end get converted to U+FFFD REPLACEMENT CHARACTER, and to be
generally compatible with TextResourceDecoder design.

r=me if you call flush() and append the result.