[webkit-reviews] review denied: [Bug 39288] Geolocation causes DOMWindow to leak if position requests are in progress when the page is navigated away : [Attachment 56503] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Steve Block <steveblock at google.com>'s
request for review:
Bug 39288: Geolocation causes DOMWindow to leak if position requests are in
progress when the page is navigated away
https://bugs.webkit.org/show_bug.cgi?id=39288

Attachment 56503: Patch
https://bugs.webkit.org/attachment.cgi?id=56503&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is one of those cases where a function by function comment in the change
log would make it more clear why your changes are correct.

> +    if (m_frame->domWindow() &&
m_frame->domWindow()->navigator()->optionalGeolocation())
> +	   m_frame->domWindow()->navigator()->optionalGeolocation()->stop();

If we’re calling m_frame->domWindow() you should not check it for 0. The code
can either call existingDOMWindow or we can remove the null check.

>  void Geolocation::disconnectFrame()
>  {
>      if (m_frame && m_frame->page() && m_allowGeolocation == InProgress)
>	  
m_frame->page()->chrome()->cancelGeolocationPermissionRequestForFrame(m_frame,
this);
> -    stopUpdating();

Is there a guarantee that no new geolocation activity can start after a frame
stops loading? What guarantees that? There is not enough explanation here,
either in change log or in comments, to make clear why this code is correct.

review- for the moment because of this one issue and one question