[webkit-reviews] review granted: [Bug 38456] [Qt] QtTestBrowser does not support websites which requires HTTP Authentication via dialogs : [Attachment 56502] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 38456: [Qt] QtTestBrowser does not support websites which requires HTTP
Authentication via dialogs
https://bugs.webkit.org/show_bug.cgi?id=38456

Attachment 56502: Patch
https://bugs.webkit.org/attachment.cgi?id=56502&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
LGTM, though it might make more sense implementing the dialog on the view site
and just call that from the WebPage.