[webkit-reviews] review canceled: [Bug 38987] [Qt] The QScriptValue autotest should be refactored. : [Attachment 55849] Fix v1.01

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 19 09:30:43 PDT 2010


Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has canceled Jędrzej Nowacki
<jedrzej.nowacki at nokia.com>'s request for review:
Bug 38987: [Qt] The QScriptValue autotest should be refactored.
https://bugs.webkit.org/show_bug.cgi?id=38987

Attachment 55849: Fix v1.01
https://bugs.webkit.org/attachment.cgi?id=55849&action=review

------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
(In reply to comment #6)
> (From update of attachment 55849 [details])
> \I didn't really like the "isXXX, toXXX". What about toType, isType, or maybe
tst_qscriptvalue_generated_typeValidation, _typeConversion?
Names were changed to totype and istype.


More information about the webkit-reviews mailing list