[webkit-reviews] review requested: [Bug 38845] Canvas color property getters should serialize them according to spec : [Attachment 56486] Proposed patch v9

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 19 07:12:01 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has asked  for review:
Bug 38845: Canvas color property getters should serialize them according to
spec
https://bugs.webkit.org/show_bug.cgi?id=38845

Attachment 56486: Proposed patch v9
https://bugs.webkit.org/attachment.cgi?id=56486&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Updated patch with null checks moved to create().
AFAICT there is no way to cause the CanvasStyle(Gradient/Pattern) constructors
to be called with invalid arguments, so I don't know how to make a test for
that.


More information about the webkit-reviews mailing list