[webkit-reviews] review canceled: [Bug 36463] Spatial Navigation: make it work with focusable elements in overflow content : [Attachment 56402] patch v5

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 36463: Spatial Navigation: make it work with focusable elements in overflow
content
https://bugs.webkit.org/show_bug.cgi?id=36463

Attachment 56402: patch v5
https://bugs.webkit.org/attachment.cgi?id=56402&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
Patch is the same as patch v5, but fixed a typo in the ChangeLog.

Summary:
- Addressed Simon's requests by extending support for travesing any scrollable
block elements that has at least one child node and is not a document node.
- Patch basically handle scrollable block elements in the same way {i}frame are
handle. Internal traversal has precedence over elements outside it.
- Patch refactories updateFocusCandidateIfCloser to work with the newly
introduced enclosingScrollableBox class member of FocusCandidate.
- As a real world testcase: patch makes pages like maps.google.com useful