[webkit-reviews] review denied: [Bug 39004] Crash on SVG feLigthing effects : [Attachment 56478] fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 19 03:18:09 PDT 2010
Dirk Schulze <krit at webkit.org> has denied Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 39004: Crash on SVG feLigthing effects
https://bugs.webkit.org/show_bug.cgi?id=39004
Attachment 56478: fix
https://bugs.webkit.org/attachment.cgi?id=56478&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
You should mention, that you avoid negeative locations for the resulting image
effect in combination with putUnmultipliedImageData.
This also needs a regression test, to avoid crashes in the feature.
The patch itself looks great. r- for the missing test and missing details on
the Changelog.
More information about the webkit-reviews
mailing list