[webkit-reviews] review canceled: [Bug 39156] FrameLoader: refactor FrameLoader::createWindow() to be a non-member, non-friend function : [Attachment 56426] Proposed patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 22:50:28 PDT 2010


Chris Jerdonek <cjerdonek at webkit.org> has canceled Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 39156: FrameLoader: refactor FrameLoader::createWindow() to be a
non-member, non-friend function
https://bugs.webkit.org/show_bug.cgi?id=39156

Attachment 56426: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=56426&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
Qualified the call to createWindow() in BindingDOMWindow.h.

The compiler was interpreting the call to createWindow() in BindingDOMWindow.h
as a dependent name because it has the same name as
BindingDOMWindow<Binding>::createWindow() -- even though the signature is
different.


More information about the webkit-reviews mailing list