[webkit-reviews] review granted: [Bug 39335] Implement the DOCTYPE states for the HTML5 lexer : [Attachment 56441] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 19:47:55 PDT 2010


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 39335: Implement the DOCTYPE states for the HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39335

Attachment 56441: Patch
https://bugs.webkit.org/attachment.cgi?id=56441&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Totally need an isWhitespace function.

	 default:
 1190		  ASSERT_NOT_REACHED();
 1191		  break;
 1192	      }

very bad.  :p  We want the compiler to warn if we're missing an enum value.


More information about the webkit-reviews mailing list