[webkit-reviews] review requested: [Bug 39318] Refactor HTMLTokenizer::write to make it more readable and split out the lexer bits from flow control bits : [Attachment 56412] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 17:37:07 PDT 2010


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 39318: Refactor HTMLTokenizer::write to make it more readable and split out
the lexer bits from flow control bits
https://bugs.webkit.org/show_bug.cgi?id=39318

Attachment 56412: Patch
https://bugs.webkit.org/attachment.cgi?id=56412&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I used run-pageloadtest cvs-base (as provided by Maciej), edited to run the
test 10 times each (instead of 3).  I discarded the first 2 runs for each (as
they seemed to be noisy).

% grep FINISHED without_patch.txt | tail -8 | awk '{s += $5; print $5} END {
print "avg: ", s/NR }'
2169.3
2179.2
2173.5
2157.4
2191.8
2179.0
2157.5
2137.7
avg:  2168.18

% grep FINISHED with_patch2.txt | tail -8 | awk '{s += $5; print $5} END {
print "avg: ", s/NR }'
2193.4
2126.9
2226.7
2207.0
2177.4
2191.7
2186.0
2177.1
avg:  2185.77

2185.77 - 2168.18 = 17.59

17.59 / 2168.18 = 0.00811279506

Is that convincing?


More information about the webkit-reviews mailing list