[webkit-reviews] review granted: [Bug 38879] new-run-webkit-tests: implement "--reset-results" : [Attachment 56428] okay, use a separate layout_tests_dir under webkitpy/layout_tests/data to isolate unit test data from actual layout tests

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted  review:
Bug 38879: new-run-webkit-tests: implement "--reset-results"
https://bugs.webkit.org/show_bug.cgi?id=38879

Attachment 56428: okay, use a separate layout_tests_dir under
webkitpy/layout_tests/data to isolate unit test data from actual layout tests
https://bugs.webkit.org/attachment.cgi?id=56428&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
WebKitTools/Scripts/webkitpy/layout_tests/port/test.py:115
 +	    with codecs.open(expectations_path, "r", "utf-8") as file:
can we just use regular open here?

WebKitTools/Scripts/webkitpy/layout_tests/test_types/image_diff.py:84
 +	      generate_new_baseline: is this a new baseline or an updated one?
This description is wrong. Makes it sound like this is actually a baseline, not
a boolean. The description you have below in test_type_base.py would be fine.
Although, I still prefer these descriptions to be statements, not questions,
e.g. "whether to generate a new baseline or update an existing one".