[webkit-reviews] review requested: [Bug 39156] FrameLoader: refactor FrameLoader::createWindow() to be a non-member, non-friend function : [Attachment 56426] Proposed patch 2

[bugzilla-daemon at webkit.org]

Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 39156: FrameLoader: refactor FrameLoader::createWindow() to be a
non-member, non-friend function
https://bugs.webkit.org/show_bug.cgi?id=39156

Attachment 56426: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=56426&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
Addressing your comments.

(In reply to comment #3)
> I'm not sure this should be a free function.	It feels like it should be a
member of something...

(In reply to comment #4)
> I also wonder if FrameLoader.h/cpp is the right place for this.

(In reply to comment #5)
> I think it would make sense for this to be the member of something, maybe a
static member, that should be responsible for creating windows. But I think
it's OK as a free function too.

I also added a FIXME to move this to a more appropriate location/class per my
comment 6.