[webkit-reviews] review granted: [Bug 39324] AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameterized attribute that it doesn't handle. : [Attachment 56417] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 39324: AX: WebKit doesn't call [super
-accessibilityAttributeValue:attribute forParameter:] when it encounters a
parameterized attribute that it doesn't handle.
https://bugs.webkit.org/show_bug.cgi?id=39324

Attachment 56417: patch
https://bugs.webkit.org/attachment.cgi?id=56417&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	   // got a parameter of a type we never use
> -	   // NOTE: No ASSERT_NOT_REACHED because this can happen accidentally
> -	   // while using accesstool (e.g.), forcing you to start over
> -	   return nil;
> +	   // Default to super if the parameter type is unknown.
> +	   return [super accessibilityAttributeValue:attribute
forParameter:parameter];

Is this right? It's a parameter we support, but a type we don't. I don't think
calling super makes a lot of sense in this case, but I guess it's harmless.

> -    return nil;
> +    // Default to super if parameter is not supported.
> +    return [super accessibilityAttributeValue:attribute
forParameter:parameter];

This seems clearly right.