[webkit-reviews] review granted: [Bug 39322] [GTK] DragClientGtk::startDrag leaks GdkEvents : [Attachment 56414] Fix memory leak

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 14:46:00 PDT 2010


Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 39322: [GTK] DragClientGtk::startDrag leaks GdkEvents
https://bugs.webkit.org/show_bug.cgi?id=39322

Attachment 56414: Fix memory leak
https://bugs.webkit.org/attachment.cgi?id=56414&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>+    GdkWindow* window = gtk_widget_get_window(GTK_WIDGET(m_webView));
>+    g_object_ref(window); // This will be decremented by gdk_event_free()
below.
>+    event->button.window = gtk_widget_get_window(GTK_WIDGET(m_webView));

just event->button.window = window; ?

r=me


More information about the webkit-reviews mailing list