[webkit-reviews] review granted: [Bug 39303] Web Inspector: fix some localization issues : [Attachment 56400] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 18 13:14:32 PDT 2010
Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 39303: Web Inspector: fix some localization issues
https://bugs.webkit.org/show_bug.cgi?id=39303
Attachment 56400: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=56400&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
WebCore/inspector/front-end/TimelinePanel.js:899
+ contentHelper._appendTextRow(WebInspector.UIString("Timer
Id"), this.data.timerId);
I'm surprised "Id" isn't "ID".
WebCore/inspector/front-end/TimelinePanel.js:921
+
contentHelper._appendTextRow(WebInspector.UIString("Mime Type"),
this.data.mimeType);
Should "Mime" be "MIME"?
Seems like the number-formatting functions should move off of the Number object
and just always use WebInspector.UIString.
r=me
More information about the webkit-reviews
mailing list