[webkit-reviews] review granted: [Bug 21945] Implement HTML5 comment parsing : [Attachment 55857] Updated HTML5 parsing - added the 2 missing states, cleaned some more old code and this time with the test cases

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 21945: Implement HTML5 comment parsing
https://bugs.webkit.org/show_bug.cgi?id=21945

Attachment 55857: Updated HTML5 parsing - added the 2 missing states, cleaned
some more old code and this time with the test cases
https://bugs.webkit.org/attachment.cgi?id=55857&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> It is a difference on our side from HTML5. I did not want to correct that as
it will lead
> to big compatibility issues (we would recognize comment starting or ending
inside a
> <script> or a <style> which we do not currently).

Sounds like this should be considered in a separate bug then. In any case, the
goal is to have an implementation that matches HTML5, and it can be achieved by
modifying either.

-Output of this test should match WinIE (no strict SGML comment parsing).
+Output of this test should match HTML5 (no strict SGML comment parsing).

Did you test with html5lib (e.g. <http://james.html5.org/parsetree.html>)?

r=me