[webkit-reviews] review granted: [Bug 39296] build-webkit doesn't recognize Platform SDK on win64 : [Attachment 56383] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 18 12:40:49 PDT 2010
Adam Roben (aroben) <aroben at apple.com> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 39296: build-webkit doesn't recognize Platform SDK on win64
https://bugs.webkit.org/show_bug.cgi?id=39296
Attachment 56383: Patch
https://bugs.webkit.org/attachment.cgi?id=56383&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> - return if -e $windowsPlatformSDKRegistryEntry;
> + return if ((-e $windowsPlatformSDKRegistryEntry) || (-e
$windows64PlatformSDKRegistryEntry));
Normally we'd omit the outer parentheses here.
r=me
More information about the webkit-reviews
mailing list