[webkit-reviews] review granted: [Bug 38232] REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li : [Attachment 55199] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 38232: REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode
when indenting in an empty li
https://bugs.webkit.org/show_bug.cgi?id=38232

Attachment 55199: Patch
https://bugs.webkit.org/attachment.cgi?id=55199&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
This looks good. The old code was clearly violating an assert in
splitTreeToNode. I would bet that an audit of call calls to splitTreeToNode
would find other cases like this. I almost wonder if splitTreeToNode should
just deal with this case (i.e. not split and just return the passed in Node),
but I'm on the fence. This is certainly fine as a fix to the crash.