[webkit-reviews] review denied: [Bug 39289] Wrong result in case of non-iterative matching of subpatterns in non-greedy cases in YARR Interpreter : [Attachment 56366] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 09:21:10 PDT 2010


Darin Adler <darin at apple.com> has denied Peter Varga <pvarga at inf.u-szeged.hu>'s
request for review:
Bug 39289: Wrong result in case of non-iterative matching of subpatterns in
non-greedy cases in YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=39289

Attachment 56366: proposed patch
https://bugs.webkit.org/attachment.cgi?id=56366&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks like a good code change. But needs a test case to demonstrate at least
one regular expression that malfunctions without this and works with it. We
don't take patches without test cases unless there's a reason a test case can't
be created.


More information about the webkit-reviews mailing list