[webkit-reviews] review denied: [Bug 38783] [chromium] Implement h/w accelerated compositing for LayerChromium layers : [Attachment 56297] Proposed patch - smaller this time

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 38783: [chromium] Implement h/w accelerated compositing for LayerChromium
layers
https://bugs.webkit.org/show_bug.cgi?id=38783

Attachment 56297: Proposed patch - smaller this time
https://bugs.webkit.org/attachment.cgi?id=56297&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
Overall, looks great.  Just a few minor issues:

WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:535
 +	// The position of they layer is the center of quad.
nit: "they layer" -> "the layer" ?

WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:264
 +		// Scrolling works as follows: We render a quad with the
current root layer contents
nit: indent by 4 spaces instead of 8.  true, this means the
body is not visually separate from the "|| (scrollDelta..."
bit, but that's what webkit style would have you do.

WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:359
 +	std::map<LayerChromium*, unsigned int>::iterator textureId;
webkit avoids the container classes from STL.  please use HashMap
from WTF instead.