[webkit-reviews] review denied: [Bug 39269] [Chromium] Windows: Determinate progress bar should have glossy overlay : [Attachment 56327] patch v0

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 39269: [Chromium] Windows: Determinate progress bar should have glossy
overlay
https://bugs.webkit.org/show_bug.cgi?id=39269

Attachment 56327: patch v0
https://bugs.webkit.org/attachment.cgi?id=56327&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>


WebCore/platform/chromium/ChromiumBridge.h:228
 +		GraphicsContext*, const IntRect& barRect, const IntRect&
valueRect, bool determinate, double time);
The name "time" is unclear.  Maybe "secondsSinceEpoch"?


WebCore/rendering/RenderThemeChromiumWin.cpp:672
 +	// So here we can return arbitrary value.
The value must be greater than 0, not arbitrary.




WebKit/chromium/public/WebThemeEngine.h:81
 +	    bool determinate, double time) {}
Ditto for "time"


WebKit/chromium/src/ChromiumBridge.cpp:683
 +	GraphicsContext* gc, const IntRect& barRect, const IntRect& valueRect,
bool determinate, double time)
ditto.

WebKit/chromium/src/ChromiumBridge.cpp:686
 +	    gc->platformContext()->canvas(), barRect, valueRect, determinate,
time);
ditto.