[webkit-reviews] review granted: [Bug 39257] Chromium: new-run-webkit-httpd fails to setup_mount : [Attachment 56309] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 39257: Chromium: new-run-webkit-httpd fails to setup_mount
https://bugs.webkit.org/show_bug.cgi?id=39257

Attachment 56309: Patch
https://bugs.webkit.org/attachment.cgi?id=56309&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:47
 +				  expected_stdout="",
These default to "", so the explicit ="" are not needed.

WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:51
 +	    orig_platform = sys.platform
I would have abstracted that code into some sort of setup/teardown function. 
If we wanted to get fancy we could use python 2.5+ contextual objects and a
with statement, but that's probably overkill.

WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:62
 +				  expected_stdout="",
Not needed, defaults to ""

LGTM otherwise.