[webkit-reviews] review canceled: [Bug 39217] Add an optional "starting node' parameter to scrollRecursively and scrollOverflow of EventHandler : [Attachment 56242] patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 17 10:59:58 PDT 2010
Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 39217: Add an optional "starting node' parameter to scrollRecursively and
scrollOverflow of EventHandler
https://bugs.webkit.org/show_bug.cgi?id=39217
Attachment 56242: patch v2
https://bugs.webkit.org/attachment.cgi?id=56242&action=review
------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
(In reply to comment #4)
> (From update of attachment 56242 [details])
> I don't think the name "fromNode" is clear enough. Argument names should be
noun phrases; there's no such thing as a "from node". Maybe "starting node" is
the right name?
Same as patch v2, but changed "fromNode" to 'startingNode"
More information about the webkit-reviews
mailing list