[webkit-reviews] review denied: [Bug 39225] [Qt] Repeat pattern should start from origin : [Attachment 56247] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 17 10:25:00 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied qi
<qi.2.zhang at nokia.com>'s request for review:
Bug 39225: [Qt] Repeat pattern should start from origin
https://bugs.webkit.org/show_bug.cgi?id=39225

Attachment 56247: patch
https://bugs.webkit.org/attachment.cgi?id=56247&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +	   Patterns must be painted so that the top left of the first image 
> +	is anchored at the origin of the coordinate space, and images are 
> +	then repeated horizontally to the left and right (if the repeat-x 
> +	string was specified) or vertically up and down (if the repeat-y 
> +	string was specified) or in all four directions all over the canvas 
> +	(if the repeat string was specified).

There is something wrong with the indentation of the above.

Missing test.

r- for the above.


More information about the webkit-reviews mailing list