[webkit-reviews] review denied: [Bug 24943] Command-B and Command-I do not generate keydown events in contentEditable regions : [Attachment 56216] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 17 09:48:55 PDT 2010
Darin Adler <darin at apple.com> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 24943: Command-B and Command-I do not generate keydown events in
contentEditable regions
https://bugs.webkit.org/show_bug.cgi?id=24943
Attachment 56216: Patch
https://bugs.webkit.org/attachment.cgi?id=56216&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
Good to see my code change in a patch for review.
> + No tests because performKeyEquivalent does not seem to be called by
DRT.
That's a reason we can't make an automated test, but a manual test should be
possible. See check-ins like <http://trac.webkit.org/changeset/58829> for
examples of how to add a manual test.
More information about the webkit-reviews
mailing list