[webkit-reviews] review denied: [Bug 39211] [Chromium] Windows: Speed of indeterminate progress bar should be constant : [Attachment 56229] patch v0

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 39211: [Chromium] Windows: Speed of indeterminate progress bar should be
constant
https://bugs.webkit.org/show_bug.cgi?id=39211

Attachment 56229: patch v0
https://bugs.webkit.org/attachment.cgi?id=56229&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
WebCore/rendering/RenderThemeChromiumWin.cpp:664
 +  static const double progressAnimationNumFrames = 60;
If this value is not used anymore, remove it.


WebCore/rendering/RenderThemeChromiumWin.cpp:665
 +  static const double progressIndeterminateOverlayDelta =  175;
Could you add a comment why this value is 175 please?
The symbol name wasn't clear to me at first glance.  I recommend to make it
contain "DeltaPerFrame" or "PixelsPerFrame".


WebCore/rendering/RenderThemeChromiumWin.cpp:667
 +  static const int progressIndeterminateOverlayWidth = 120;
ditto