[webkit-reviews] review granted: [Bug 37664] Chromium: Add --chromium option to new-run-webkit-websocketserver : [Attachment 56210] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 16 23:59:51 PDT 2010


Eric Seidel <eric at webkit.org> has granted Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 37664: Chromium: Add --chromium option to new-run-webkit-websocketserver
https://bugs.webkit.org/show_bug.cgi?id=37664

Attachment 56210: Patch
https://bugs.webkit.org/attachment.cgi?id=56210&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm uncertain if we should be returning a copy of os.environ or not.
 426	     return os.environ

Your change does not change behavior though, so it's fine.


More information about the webkit-reviews mailing list