[webkit-reviews] review canceled: [Bug 39184] Add support for parsing a SVN property : [Attachment 56205] Patch with unit tests

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has canceled Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 39184: Add support for parsing a SVN property
https://bugs.webkit.org/show_bug.cgi?id=39184

Attachment 56205: Patch with unit tests
https://bugs.webkit.org/attachment.cgi?id=56205&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Spoke with Chris tonight, and we decided to change the line "if
($propertyChangeDelta == -1 * $expectedChangeDelta)" to  "if
($expectedChangeDelta && $propertyChangeDelta != $expectedChangeDelta)" to make
it clearer to a reader that we should only die if the property change type
(e.g. "Added") differs from the property value type (e.g. "+"), for "Added" and
"Deleted" change types only.