[webkit-reviews] review requested: [Bug 39184] Add support for parsing a SVN property : [Attachment 56204] Patch with unit tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 16 18:22:19 PDT 2010
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 39184: Add support for parsing a SVN property
https://bugs.webkit.org/show_bug.cgi?id=39184
Attachment 56204: Patch with unit tests
https://bugs.webkit.org/attachment.cgi?id=56204&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
Updated patch based on Chris's suggestions.
Added test cases:
"add svn:executable, followed by empty line"
"add svn:executable, followed by empty line and start of binary patch"
"single-line '-' change with trailing new line, and single-line '+' change"
"multi-line '-' change with trailing new line, and multi-line '+' change"
"single-line '+' with trailing new line, followed by empty line and start of
binary patch"
"single-line '+' change followed by custom property with single-line '+'
change"
More information about the webkit-reviews
mailing list