[webkit-reviews] review granted: [Bug 38344] Remove custom bindings for HTMLInputElement : [Attachment 56141] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 38344: Remove custom bindings for HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=38344

Attachment 56141: Patch
https://bugs.webkit.org/attachment.cgi?id=56141&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Good to avoid custom bindings.

Awkward to have these two versions of these basic functions side by side. The
only other place I can think of where we have that is the Range class. Note the
different way these functions are declared in that class compared to what we
have in this patch. I think I like the Range style slightly better.

> +    // The methods that take ExceptionCodes check canHaveSelection().

Methods is not a C++ term, and I normally avoid using it to mean member
function in WebKit code. I would say "The following functions" or "These
functions" rather than "The methods".