[webkit-reviews] review canceled: [Bug 38845] Canvas color property getters should serialize them according to spec : [Attachment 56129] Proposed patch v6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 14 19:16:40 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has canceled Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 38845: Canvas color property getters should serialize them according to
spec
https://bugs.webkit.org/show_bug.cgi?id=38845

Attachment 56129: Proposed patch v6
https://bugs.webkit.org/attachment.cgi?id=56129&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Updated patch - v6 missed one instance of "...would be slightly clearer if it
used a local variable for the result of parseColor instead of setting m_rgba
first to the wrong value and then the right one..."


More information about the webkit-reviews mailing list